-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: perfection tracker for levels with best number of commands #1204
Conversation
✅ Deploy Preview for xenodochial-hugle-b9ec84 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Oh cool feature! Do you have a screenshot of what the UI looks like? My only worry is this part: learnGitBranching/src/js/stores/LevelStore.js Lines 51 to 57 in 928577b
Since we sync that map to local storage, I think this existing code would wipe out the existing solved map status. I think we can fix that in the |
A star would be cool!! I added a fix for old users: it works now :) |
its just a matter of changing react-ok-icon to react-star class on the tag. |
That would be in the
I would add another icon and then just conditionally show or hide the icon based on CSS rules :) |
This feature introduces the ability to track and record the user's best performance on each level. By storing both the completion status (solved) and whether the user achieved the best possible outcome (best), the application can provide more detailed feedback and track user improvement over time.